Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config method merge bug #145

Closed
shaukei opened this issue Feb 17, 2022 · 1 comment · Fixed by #147
Closed

Config method merge bug #145

shaukei opened this issue Feb 17, 2022 · 1 comment · Fixed by #147
Labels
bug
Milestone
3.0.1

Comments

@shaukei
Copy link

shaukei commented Feb 17, 2022 •
edited

image

PR:
class AbstractConfig:
public function merge(ConfigInterface $config)
{
$this->data = array_replace_recursive($this->data, $config->all());
+++ $this->cache = [];
return $this;
}
@DavidePastore
Copy link
Collaborator

Hi @shaukei. Thanks for reporting this.

@DavidePastore DavidePastore added this to the Future Release milestone Mar 26, 2022
DavidePastore added a commit that referenced this issue Mar 26, 2022
@DavidePastore
Fix merge
830e8b2 
Closed #145
@DavidePastore DavidePastore mentioned this issue Mar 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

Fix merge hassankhan/config
2 participants
@shaukei @DavidePastore