New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method offsetUnset does not remove key #123
Comments
Ok, I will try to create a fix. |
There are a few possible solutions how to fix this:
So, I would most like 1st or 3rd solution. @prwater @DavidePastore @hassankhan What do you think? |
@filips123 Sorry for the delay and thanks for your recap. I think that the best solution is the first one, even if it breaks the interface. We could add it as a new major release to be sure that developers have to upgrade their code to make it works. |
Method
\Noodlehaus\AbstractConfig::offsetUnset
(Deletes a key and its value) does not remove the key from the configuration but only set the value of the key tonull
.The following code:
yields the following output:
The key
application
is still in the configuration (with valuenull
).Unit test
\Noodlehaus\AbstractConfigTest\testRemove
must useassertArrayNotHasKey
instead ofassertNull
:The text was updated successfully, but these errors were encountered: