Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where a source hash key can be used in translating multip… #547

Merged
merged 1 commit into from Nov 8, 2021
Merged

Fixed issue where a source hash key can be used in translating multip… #547

merged 1 commit into from Nov 8, 2021

Conversation

danwa5
Copy link
Contributor

@danwa5 danwa5 commented Jun 17, 2021 •
edited by michaelherold

…le properties

Fixes #546

@danwa5 danwa5 force-pushed the issue-546-trash-properties branch from 82094da to 382100e Compare June 17, 2021 21:11
@danwa5 danwa5 force-pushed the issue-546-trash-properties branch from 382100e to e295a0d Compare June 17, 2021 21:18
michaelherold
michaelherold approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@michaelherold michaelherold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! It's unfortunate that we have this logical duplication but that's due to how ad-hoc the behavior is.

@michaelherold
Copy link
Member

I will get this merged as soon as we get #543 merged. Should be soon! We'll get a release out shortly after.

@dblock dblock merged commit a979d72 into hashie:master Nov 8, 2021
@dblock
Copy link
Member

dblock commented Nov 8, 2021

I merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelherold michaelherold michaelherold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple Trash properties that use the same key from a source hash
3 participants
@danwa5 @michaelherold @dblock