Run 2.7 tests once #539
Merged
Run 2.7 tests once #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakinj
force-pushed
the
run-27-ci-only-once
branch
from
974abf8
to
f8585e2
Compare
anakinj
force-pushed
the
run-27-ci-only-once
branch
from
f8585e2
to
96b42ea
Compare
|
Why the jruby tests are failing is most probably something unrelated to this change. |
|
#538 is trying to fix this, feel free to include some of it here to expedite |
|
Oh, did not notice there were things going on related to those. If the jruby tests are broken anyway at the moment, would it be easiest to just have this go into master and into #538 via a rebase, if you see value in this minor change. |
|
or then the other way around, this can wait for the changes in #538 to hit master. |
|
If we have your attention, make the minimal changes to fix the build here. |
|
By "minimal change" i assume you mean dropping the flaky jruby build. That was done just a moment ago. |
dblock
approved these changes
Oct 26, 2020
anakinj
force-pushed
the
run-27-ci-only-once
branch
from
e0280c5
to
cc41edd
Compare
michaelherold
added
the
hacktoberfest-accepted
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using this projects Travis CI configuration as a reference on how one could execute the CodeClimate job and noticed that the tests for Ruby 2.7 were executed twice.
This change leaves the responsibility for testing 2.7 to the Danger+CodeClimate job.