Drop testing for JRuby 9.0 #538
Conversation
|
I'm a little hesitant to drop testing because of things like Omniauth that have a direct dependency on this, but not hesitant enough to block this. If we officially drop 2.4 support, I'd say we do another major version bump. We don't wanna have to rely on remembering in a future PR when someone decides to use a ruby 2.5 method |
|
That's fair. I don't want to drop support until the next major, but
dropping testing for JRuby 9.0 seems necessary because the suite is
randomly failing.
I decided to take the bigger bite for some feedback.
…On Sat, Oct 24, 2020, 5:27 AM Bobby McDonald ***@***.***> wrote:
I'm a little hesitant to drop testing because of things like Omniauth that
have a direct dependency on this, but not hesitant enough to block this. If
we officially drop 2.4 support, I'd say we do another major version bump.
We don't wanna have to rely on remembering in a future PR when someone
decides to use a ruby 2.5 method
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#538 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADHXAJCKBTIWUVHENC3AR3SMKT2BANCNFSM4S5JCCHQ>
.
|
|
OK to merge on 🍏. "Miscellaneous" isn't a valid section of a CHANGELOG per format, put the removal of support into "Removed" |
CHANGELOG.md
Outdated
| @@ -45,6 +45,11 @@ Any violations of this scheme are considered to be bugs. | |||
|
|
|||
| * Your contribution here. | |||
|
|
|||
| ### Miscellaneous | |||
|
|
|||
| * [#538](https://github.com/hashie/hashie/pull/538): Dropped testing on outdated Rubies, though not necessarily support - [@michaelherold](https://github.com/michaelherold). | |||
There was a problem hiding this comment.
I think you should be explicit in what's dropped, e.g. "Ruby 2.1, 2.2, 2.3 and 2.4 are no longer supported".
I vote to keep them though, unless the build is failing though, or we have another reason to drop the versions, for a little longer. Hashie is fairly low level library and we don't want to force deprecations too broadly, it creates work for everyone.
There was a problem hiding this comment.
Roger that. I will back it out to just JRuby 9.0 before merging.
Re: Miscellaneous, I am surprised about that. I thought that there was one.
michaelherold
force-pushed
the
drop-testing-for-old-rubies
branch
2 times, most recently
from
8c22f3d
to
629603d
Compare
Per the [JRuby security policy][1], JRuby 9.2 is supported, but 9.0 is not any longer. JRuby 9.0 has been flaky on builds, so it's now causing a maintenance burden. This isn't a declaration that we won't support this version, but I don't think it makes sense to test on them any more. In the next major release, I would like to define a support policy. [1]: https://github.com/jruby/jruby/blob/4fd5e619f9d1f36d7bbca8f0013bb55e4ad57e8f/SECURITY.md
michaelherold
force-pushed
the
drop-testing-for-old-rubies
branch
from
629603d
to
88dabce
Compare
michaelherold
changed the title
michaelherold
added
the
hacktoberfest-accepted
Per the JRuby security policy, JRuby 9.2 is supported, but 9.0 is
not any longer.
JRuby 9.0 has been flaky on builds, so it's now causing a maintenance
burden.
This isn't a declaration that we won't support this version, but I
don't think it makes sense to test on it anymore. In the next major
release, I would like to define a support policy.