Hashie::Extensions::Dash::PredefinedValues #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalberts
force-pushed
the
dash-allowed-values
branch
3 times, most recently
from
d9b11e1
to
b465c9c
Compare
|
I like it. Naming-wise I think we don't want to get into the business of having allow and deny lists (which can become incompatible, etc.), so I still think it should be |
dblock
requested changes
Sep 19, 2020
caalberts
force-pushed
the
dash-allowed-values
branch
2 times, most recently
from
e9be2d6
to
4f8d65f
Compare
Extends a Dash with the ability to accept only predefined values on a property. hashie#61
caalberts
force-pushed
the
dash-allowed-values
branch
from
4f8d65f
to
4cd2844
Compare
dblock
approved these changes
Sep 22, 2020
|
Leaving this open for a bit to hear from other maintainers and will merge sometime by EOW otherwise. |
dblock
changed the title
|
Does anyone feel strongly about whether this should be called |
michaelherold
approved these changes
Sep 24, 2020
|
Thanks @dblock @michaelherold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends a Dash with the ability to accept only predefined values on a property.
#61