New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move integration tests to use inline Gemfiles #445
Comments
Hi, I am interested to contribute towards this. |
What I'm looking for here is a simplification of our integration test setup. The implementation is a suggestion: if there's a different way you want to go about attempting it, that would be fine too. Ideally, the variables I would like to optimize for are:
I think that inline bundles will help with both of those, but there could be a different way to solve the problem. |
I read the |
@michaelherold Other integration spec directories had multiple files, thus the point of eliminating the Gemfile in these directory meant writing gem requirements of each of these files at the beginning and thus doesn't looked much promising to me as writing new integration specs in future would require this to be done every time and I think is cumbersome. I decided not to follow this. The What are your thoughts? |
Our integration tests currently use an external Gemfile to the test. This means that in order to onboard into contributing, you have to go through the tedious process of running
bundle install
within each of the integration tests' folders.It would be great to move the Bundler configuration into using
bundler/inline
, like the Rails bug report templates to make them more reliable and easier to start using.While we're at it, we could reorganize the integration specs to be single files instead of the
spec/integration/<name>/integration_spec.rb
pattern.For example:
spec/integration/elasticsearch/integration_spec.rb
could becomespec/integration/elasticsearch_spec.rb
The text was updated successfully, but these errors were encountered: