From f688fd1caafb6e878f8bec839661b5e1f733f2cf Mon Sep 17 00:00:00 2001 From: Jack Jennings Date: Tue, 6 Apr 2021 17:45:02 -0700 Subject: [PATCH] Add #except under Ruby 3 Ruby 3 adds the Hash#except method --- .travis.yml | 1 + lib/hashie/extensions/indifferent_access.rb | 7 +++++++ lib/hashie/mash.rb | 7 +++++++ spec/hashie/extensions/indifferent_access_spec.rb | 12 ++++++++++++ spec/hashie/mash_spec.rb | 13 +++++++++++++ 5 files changed, 40 insertions(+) diff --git a/.travis.yml b/.travis.yml index 49230a12..a15d23ea 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,6 +2,7 @@ language: ruby cache: bundler rvm: + - 3.0 - 2.6 - 2.5 - 2.4 diff --git a/lib/hashie/extensions/indifferent_access.rb b/lib/hashie/extensions/indifferent_access.rb index d6b9da33..0392baee 100644 --- a/lib/hashie/extensions/indifferent_access.rb +++ b/lib/hashie/extensions/indifferent_access.rb @@ -162,6 +162,13 @@ def slice(*keys) end end + with_minimum_ruby('3.0.0') do + def except(*keys) + string_keys = keys.map { |key| convert_key(key) } + slice(*self.keys - string_keys) + end + end + protected def hash_lacking_indifference?(other) diff --git a/lib/hashie/mash.rb b/lib/hashie/mash.rb index f72633d2..b9fea722 100644 --- a/lib/hashie/mash.rb +++ b/lib/hashie/mash.rb @@ -351,6 +351,13 @@ def transform_keys(&blk) end end + with_minimum_ruby('3.0.0') do + def except(*keys) + string_keys = keys.map { |key| convert_key(key) } + slice(*self.keys - string_keys) + end + end + protected def method_name_and_suffix(method_name) diff --git a/spec/hashie/extensions/indifferent_access_spec.rb b/spec/hashie/extensions/indifferent_access_spec.rb index 0aec787f..27585f11 100644 --- a/spec/hashie/extensions/indifferent_access_spec.rb +++ b/spec/hashie/extensions/indifferent_access_spec.rb @@ -357,6 +357,18 @@ def indifferent_writer(key, value) end end end + + with_minimum_ruby('3.0.0') do + describe '#except' do + let(:h) { subject.build(foo: 'bar', baz: 'qux') } + + it 'indifferently excepts keys from the hash' do + sliced_h = { 'baz' => 'qux' } + expect(h.except('foo')).to eq sliced_h + expect(h.except(:foo)).to eq sliced_h + end + end + end end describe 'with merge initializer' do diff --git a/spec/hashie/mash_spec.rb b/spec/hashie/mash_spec.rb index 4731985c..84a28ead 100644 --- a/spec/hashie/mash_spec.rb +++ b/spec/hashie/mash_spec.rb @@ -1097,4 +1097,17 @@ class SubMash < Hashie::Mash end end end + + with_minimum_ruby('3.0.0') do + context '#except' do + subject(:mash) { described_class.new(a: 'A', b: 'B') } + it 'return a Hashie::Mash' do + expect(mash.except(:b)).to be_kind_of(described_class) + end + + it 'excludes keys' do + expect(mash.except(:b)).to eq('a' => 'A') + end + end + end end