Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

gRPC health check "ValidationError: Health check matcher HTTP code cannot be empty" #4868

Open
davidmytton opened this issue Aug 4, 2023 · 0 comments
Labels

Comments

@davidmytton
Copy link

Describe the bug
Specifying a health_check within a "aws-ecs" deploy block with a grpc_code causes a validation error requiring a matcher option that isn't relevant for gRPC health checks.

Steps to Reproduce
Use a waypoint.hcl file similar to:

deploy {
    use "aws-ecs" {
      ...
      health_check {
        path = "/health"
        grpc_code = 0
        interval = 30
        timeout = 10
      }
    }
  }

Will result in an error:

❌ Initializing deployment...
✓ Discovered service subnets
✓ Discovered alb subnets
✓ Using external security group decide-inbound
✓ Using specified security group IDs
❌ Initiating target group creation...2023-08-04T12:16:18.299+0100 [DEBUG] waypoint.runner: opening job stream: retry=false
2023-08-04T12:16:18.299+0100 [TRACE] waypoint.runner: sending job request
2023-08-04T12:16:18.299+0100 [INFO]  waypoint.runner: waiting for job assignment
2023-08-04T12:16:18.820+0100 [WARN]  waypoint: job failed: job_id=01H70469TQAJ6K3Z8PD4PRSAF7 code=Unknown
  message=
  | failed to create deployment resources: 2 errors occurred:
  |     * rpc error: code = Internal desc = failed to create target group: ValidationError: Health check matcher HTTP code cannot be empty
  |     status code: 400, request id: 530584ba-3875-4872-a22f-bf50b50cd385
  |     * Error during rollback: 1 error occurred:
  |     * argument cannot be satisfied: type: ecs.WorkspaceDestroy. This is a bug in the go-argmapper library since this shouldn't happen at this point.

Expected behavior

It should deploy the ALB with the configured gRPC health check.

Waypoint Platform Versions

$ waypoint --version  
CLI: v0.11.3 (2933d41)
Server: hcp v0.12.0

Additional context

If a matcher is provided, that also errors:

Unsupported argument; An argument named "matcher" is not expected here.
@davidmytton davidmytton added the new label Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant