Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Azure ACI: Does not Destroy #4787

Open
F0otsh0T opened this issue Jun 6, 2023 · 1 comment
Open

Azure ACI: Does not Destroy #4787

F0otsh0T opened this issue Jun 6, 2023 · 1 comment
Labels
bug Something isn't working jira Will add an Issue to Jira plugin/azure

Comments

@F0otsh0T
Copy link

F0otsh0T commented Jun 6, 2023

Describe the bug
waypoint destroy does not remove the Azure resources created via Waypoint

Steps to Reproduce
Using Waypoint Tutorial to spin up an Application on Azure, I was able to spin up the Container in Azure after Joe Rajewski made some changes on the Auth as documented in this Issue @ this PR. When it came time to waypoint destroy, it never removed the Azure resources (Containers) created in the Tutorial.

I asked Joe Rajewski about this and his quote:

"just took a quick look through the code. it looks like the Destroyer interface of the plugin SDK isn't implemented for the Azure ACI plugin"

"That's a bit more work than the fix for the auth, so the team will need to prioritize that in the backlog - could you make a GitHub issue on hashicorp/waypoint about this (adding destroy functionality to the Azure ACI plugin)?"

Please include any waypoint.hcl files if applicable, as well as a
GitHub Gist of any relevant logs or steps to
reproduce the bug. Running waypoint commands with -v up to -vvv will
include any additional debugging info in the log.

Expected behavior
waypoint destroy with Azure ACI should destroy the resources created from waypoint up

Waypoint Platform Versions
Additional version and platform information to help triage the issue if
applicable:

  • Waypoint CLI Version: /Users/jychen/_tmp/waypoint/waypoint/waypointaz version
    CLI: v0.11.0-403-g1aa0706fa (1aa0706), CLI: v0.11.1
  • Waypoint Server Platform and Version: (like docker, nomad, kubernetes) docker
  • Waypoint Plugin: (like aws/ecs, pack, azure) Acure ACI

Additional context
Add any other context about the problem here.

@F0otsh0T F0otsh0T added the new label Jun 6, 2023
@cicoyle
Copy link
Contributor

cicoyle commented Jun 7, 2023

Hey @F0otsh0T, thanks for documenting this. It looks like we might've missed adding the destroy functionality to this plugin upon our initial implementation of waypoint destroy like Joe said.

@cicoyle cicoyle added bug Something isn't working jira Will add an Issue to Jira plugin/azure and removed new labels Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working jira Will add an Issue to Jira plugin/azure
Projects
None yet
Development

No branches or pull requests

2 participants