Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tests for terraform init based completions #1747

Closed
wants to merge 34 commits into from

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Apr 23, 2024

This PR adds multiple test cases for certain completions that are using schemas that Terraform downloaded during init.
It also refactors the test setup to allow for multiple directories containing fixtures. See the first two commits for that.

Todos

  • Fix zero tests running on windows (maybe path.resolve creates something not expected by the test framework)
  • Fix tests failing in CI

@ansgarm ansgarm changed the title add init tests feat: Add tests for init Apr 23, 2024
unignore .vscode dir, as committing settings for certain tests seems better than setting that in test cases (and easily forgotting to unset them for following tests in the same suite)
todo: this currently breaks the downloaded provider testcase and I don't know why. It's reproducible. A longer waiting time does not fix it. It can be fixed by removing git_module.tf. It works if init had been run before the test (either in terminal or still there from a previous run). So this hints at the LS doing weird things and not updating for unknown reasons
@ansgarm ansgarm changed the title feat: Add tests for init feat: add tests for terraform init based completions Apr 26, 2024
@dbanck
Copy link
Member

dbanck commented May 16, 2024

Superseded by #1749

@dbanck dbanck closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants