-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tests for terraform init
based completions
#1747
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unignore .vscode dir, as committing settings for certain tests seems better than setting that in test cases (and easily forgotting to unset them for following tests in the same suite)
todo: this currently breaks the downloaded provider testcase and I don't know why. It's reproducible. A longer waiting time does not fix it. It can be fixed by removing git_module.tf. It works if init had been run before the test (either in terminal or still there from a previous run). So this hints at the LS doing weird things and not updating for unknown reasons
…d confuses our Language Server
ansgarm
changed the title
feat: Add tests for init
feat: add tests for Apr 26, 2024
terraform init
based completions
Superseded by #1749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple test cases for certain completions that are using schemas that Terraform downloaded during
init
.It also refactors the test setup to allow for multiple directories containing fixtures. See the first two commits for that.
Todos
path.resolve
creates something not expected by the test framework)