Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFC: Fall back to displaying raw log if no JSON is received #1650

Open
radeksimko opened this issue Dec 8, 2023 · 0 comments
Open

TFC: Fall back to displaying raw log if no JSON is received #1650

radeksimko opened this issue Dec 8, 2023 · 0 comments
Labels
enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor

Comments

@radeksimko
Copy link
Member

Background

As part of further testing of the plan panel, as implemented in #1590 (currently not part of a release yet), it became clear that there's a bug in the TFC API.

We check here prior to deciding whether to treat the log as structured JSON or raw plaintext.

In most cases, the TFC API will behave correctly and return the right value (true only if the output is in fact JSON). However, there are cases, such as when terraform init fails, when the API returns true but still provides non-structured output.

UX Impact:

2023-12-08 14 56 58

Proposal

Fall back to displaying raw log via content provider if we receive no JSON.

@radeksimko radeksimko added enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor
Projects
None yet
Development

No branches or pull requests

1 participant