agent: add disable_keep_alives configurable #16479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Jul 27, 2022
api/client.go
Outdated
Comment on lines
771
to
772
| c.config.modifyLock.Lock() | ||
| defer c.config.modifyLock.Unlock() |
swenson
reviewed
Jul 27, 2022
| @@ -507,10 +511,14 @@ func (c *AgentCommand) Run(args []string) int { | |||
| return 1 | |||
| } | |||
|
|
|||
| if config.DisableIdleConnsAutoAuth { | |||
| if config.DisableIdleConnsCaching { | |||
There was a problem hiding this comment.
Why did this change for proxyClient, but not for the other clients?
There was a problem hiding this comment.
Was actually a bug I found, this should have been checking cache/proxy.
swenson
approved these changes
Jul 28, 2022
calvn
approved these changes
Jul 28, 2022
swenson
added a commit
to hashicorp/vault-k8s
that referenced
this pull request
Jul 28, 2022
Follow up for hashicorp/vault#16479, which added support for `disable_keep_alives` This is used very similarly to `disable_idle_connections`, which was added in #366 This adds the `disable_keep_alives` setting into the injected agent's config, which can be specified per pod: ```yaml metadata: annotations: vault.hashicorp.com/agent-disable-keep-alives: "auto-auth,caching,templating" ``` globally in the injector through the helm command when deploying: ```sh helm install vault hashicorp/vault \ --set injector.extraEnvironmentVars.AGENT_INJECT_DISABLE_KEEP_ALIVES="auto-auth\,caching\,templating" ``` or through the helm `values.yaml` file: ```yaml injector: extraEnvironmentVars: AGENT_INJECT_DISABLE_KEEP_ALIVES: "auto-auth,caching,templating" ``` This was copied almost verbatim from #366, so thanks @tvoran :) Co-authored-by: Theron Voran <theron@hashicorp.com>
swenson
added a commit
to hashicorp/vault-k8s
that referenced
this pull request
Jul 28, 2022
Support disable_keep_alives Follow up for hashicorp/vault#16479, which added support for `disable_keep_alives` This is used very similarly to `disable_idle_connections`, which was added in #366 This adds the `disable_keep_alives` setting into the injected agent's config, which can be specified per pod: ```yaml metadata: annotations: vault.hashicorp.com/agent-disable-keep-alives: "auto-auth,caching,templating" ``` globally in the injector through the helm command when deploying: ```sh helm install vault hashicorp/vault \ --set injector.extraEnvironmentVars.AGENT_INJECT_DISABLE_KEEP_ALIVES="auto-auth\,caching\,templating" ``` or through the helm `values.yaml` file: ```yaml injector: extraEnvironmentVars: AGENT_INJECT_DISABLE_KEEP_ALIVES: "auto-auth,caching,templating" ``` This was copied almost verbatim from #366, so thanks @tvoran :) Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #15986.
This PR adds a new configurable,
disable_keep_alives, which takes a string list to disable keep alives for various features in Vault Agent (auto-auth,cachingandtemplating).A small example can be found here: