Added a small utility method to display a warnings. #16441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will print warning if flag is passed after arguments e.g. vault <command> -a b -c In this example -c will be interpreted as an argument which may be misleading
|
|
calvn
reviewed
Jul 26, 2022
command/base.go
Outdated
Comment on lines
592
to
595
| printArgsWarningIfAny(&out, f.Args()) | ||
| if out.String() != "" { | ||
| f.ui.Warn(out.String()) | ||
| } |
There was a problem hiding this comment.
Alternatively, you can have printArgsWarningIfAny return the warning as a string, and output the string if it's non-empty.
tomhjp
reviewed
Jul 27, 2022
* returning string value instead of using output buffer * rephrased warning message for clarity
austingebauer
approved these changes
Jul 27, 2022
tomhjp
approved these changes
Jul 27, 2022
calvn
approved these changes
Jul 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will print warning if flag is passed after positional arguments e.g.
vault <command> -a b -cIn this example
-cwill be interpreted as an argument because go-flag stops parsing after the first non-flag arg.This behaviour may cause confusion or commands to run with unexpected results.
The decision to display a warning instead of crashing was to avoid potentially breaking existing scripts and integrations.
Small clean-up:
f