Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command/audit: improve audit enable type missing error message #16409

Merged
merged 2 commits into from Jul 21, 2022
Merged

command/audit: improve audit enable type missing error message #16409

merged 2 commits into from Jul 21, 2022

Conversation

jasonodonnell
Copy link
Contributor

Just a small improvement to the returned error message if you don't include the audit device type:

[~] vault audit enable
Missing TYPE!

The new error message looks like this:

[~] vault audit enable
Error enabling audit device: audit type missing. Valid types include 'file', 'socket' and 'syslog'.

swayne275
swayne275 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@swayne275 swayne275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!

@jasonodonnell jasonodonnell enabled auto-merge (squash) July 21, 2022 20:29
@jasonodonnell jasonodonnell added this to the 1.12.0-rc1 milestone Jul 21, 2022
@jasonodonnell jasonodonnell merged commit 522f14a into main Jul 21, 2022
@jasonodonnell jasonodonnell deleted the audit-message branch July 21, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccapurso ccapurso ccapurso approved these changes

@swayne275 swayne275 swayne275 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasonodonnell @ccapurso @swayne275