Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add value length check to approle createHMAC #14746

Merged
merged 3 commits into from Mar 29, 2022
Merged

add value length check to approle createHMAC #14746

merged 3 commits into from Mar 29, 2022

Conversation

ccapurso
Copy link
Contributor

Prevent clients from issuing approle login requests with unbounded input requiring SHA256 HMAC calculation by adding a limit check.

@vercel vercel bot temporarily deployed to Preview – vault March 28, 2022 20:37 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 28, 2022 20:37 Inactive
@ccapurso ccapurso requested review from a team March 29, 2022 14:20
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 29, 2022 14:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 29, 2022 14:22 Inactive
Copy link
Contributor

@hghaf099 hghaf099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants