UI: Allow metrics view without config read #12348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
reviewed
Aug 18, 2021
|
|
||
| import authPage from 'vault/tests/pages/auth'; | ||
| import logout from 'vault/tests/pages/logout'; | ||
| import consoleClass from 'vault/tests/pages/components/console/ui-panel'; |
There was a problem hiding this comment.
thanks for adding test coverage
Monkeychip
approved these changes
Aug 18, 2021
hashishaw
added a commit
that referenced
this pull request
Aug 19, 2021
* pass default value for defaultSpan on pricing metrics dates component * Add changelog * Add test for no config policy
hashishaw
added a commit
that referenced
this pull request
Aug 19, 2021
* pass default value for defaultSpan on pricing metrics dates component * Add changelog * Add test for no config policy
hashishaw
added a commit
that referenced
this pull request
Aug 19, 2021
* pass default value for defaultSpan on pricing metrics dates component * Add changelog * Add test for no config policy
This was referenced Aug 19, 2021
hashishaw
added a commit
that referenced
this pull request
Aug 19, 2021
hashishaw
added a commit
that referenced
this pull request
Aug 19, 2021
hashishaw
added a commit
that referenced
this pull request
Aug 20, 2021
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
* pass default value for defaultSpan on pricing metrics dates component * Add changelog * Add test for no config policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if config is not read, the metrics do not render correctly due to badly assigned default value. Now, the parent component passes in a valid value even if the one read from config is not available. Notice in the screenshot, the config tab is still not visible if the user cannot read the config endpoint