Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft: Set BatchApplyCh for more consistent batch sizes #11907

Merged
merged 2 commits into from Jun 21, 2021
Merged

Conversation

briankassouf
Copy link
Member

See hashicorp/raft#445 and hashicorp/raft#124 for more details

@briankassouf briankassouf added this to the 1.8 milestone Jun 21, 2021
@briankassouf briankassouf requested a review from a team June 21, 2021 17:16
Copy link
Contributor

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the implications of this breaking the timeout contract in Apply, but I take it you do and aren't concerned about it?

@briankassouf
Copy link
Member Author

That's correct, we don't currently use the timeout feature so that shouldn't affect us

applyFuture = b.raft.Apply(commandBytes, 0)

@vercel vercel bot temporarily deployed to Preview – vault-storybook June 21, 2021 17:55 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 21, 2021 17:55 Inactive
@briankassouf briankassouf merged commit 053a7f2 into main Jun 21, 2021
@briankassouf briankassouf deleted the raft-batching branch June 21, 2021 19:00
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
* raft: Set BatchApplyCh for more consistent batch sizes

* Add changelog file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants