Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udate to Go 1.16.5 #11802

Merged
merged 4 commits into from Jun 9, 2021
Merged

Udate to Go 1.16.5 #11802

merged 4 commits into from Jun 9, 2021

Conversation

vishalnayak
Copy link
Member

No description provided.

@vercel vercel bot temporarily deployed to Preview – vault June 9, 2021 14:02 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook June 9, 2021 14:02 Inactive
@vishalnayak vishalnayak requested a review from a team June 9, 2021 14:03
@ncabatoff
Copy link
Contributor

I see other 1.16.2 references in the tree, e.g. pkgs.yml, packages-oss.yml.

@vishalnayak
Copy link
Member Author

I suspected something was amiss when make packages didn't result in a diff. I'll look as to why.

@vercel vercel bot temporarily deployed to Preview – vault-storybook June 9, 2021 14:12 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 9, 2021 14:12 Inactive
@ncabatoff
Copy link
Contributor

Can you also do go_test.yml? Sorry I forgot to mention that one in my last comment.

@vercel vercel bot temporarily deployed to Preview – vault-storybook June 9, 2021 14:18 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 9, 2021 14:18 Inactive
@vishalnayak
Copy link
Member Author

I was wondering why .circleci/config.yml was not fully updated with 1.16.2. Updating go_test.yml and then running make ci-config did it!

@vishalnayak vishalnayak merged commit 6b3f3df into master Jun 9, 2021
@vishalnayak vishalnayak deleted the update-go branch June 9, 2021 14:38
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
* Udate to Go 1.16.5

* Add CL

* Update packages-oss.yml

* Update go_test.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants