Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Agent Auth with GCP to use new SignJWT endpoint #11473

Merged
merged 4 commits into from Apr 30, 2021

Conversation

catsby
Copy link
Member

@catsby catsby commented Apr 26, 2021

Updates Vault Agent's GCP auth to use GCP's IAM Service Account Credential endpoint for signing JWTs, as the IAM endpoint versions are deprecated. See https://cloud.google.com/iam/docs/migrating-to-credentials-api for more information on the deprecation and migration.

See also for more backstory:

Copy link
Member

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit (that would result in a slightly larger diff but ends up being less confusing), otherwise looks good.

command/agent/auth/gcp/gcp.go Outdated Show resolved Hide resolved
@calvn calvn requested a review from tvoran April 27, 2021 17:11
@vercel vercel bot temporarily deployed to Preview – vault April 28, 2021 17:21 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 28, 2021 17:21 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 29, 2021 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 29, 2021 19:26 Inactive
changelog/11473.txt Outdated Show resolved Hide resolved
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 30, 2021 15:39 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 30, 2021 15:39 Inactive
@catsby catsby merged commit 2a8c36b into master Apr 30, 2021
catsby added a commit that referenced this pull request Apr 30, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint

* use iamcredentials name instead of renaming the package on import

* add changelog

* Update changelog/11473.txt

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
catsby added a commit that referenced this pull request Apr 30, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint

* use iamcredentials name instead of renaming the package on import

* add changelog

* Update changelog/11473.txt

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
catsby added a commit that referenced this pull request Apr 30, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint

* use iamcredentials name instead of renaming the package on import

* add changelog

* Update changelog/11473.txt

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@catsby catsby deleted the agent-update-signjwt branch May 3, 2021 13:45
calvn pushed a commit that referenced this pull request May 7, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint

* use iamcredentials name instead of renaming the package on import

* add changelog

* Update changelog/11473.txt

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
AndreyZamyslov pushed a commit to yandex-cloud/vault that referenced this pull request Jun 10, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint

* use iamcredentials name instead of renaming the package on import

* add changelog

* Update changelog/11473.txt

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
* Update Agent Auth with GCP to use new SignJWT endpoint

* use iamcredentials name instead of renaming the package on import

* add changelog

* Update changelog/11473.txt

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants