From 342827be41cd922e5611a9a40faf6e54836068c1 Mon Sep 17 00:00:00 2001 From: Nick Cabatoff Date: Thu, 15 Apr 2021 13:45:51 -0400 Subject: [PATCH 1/2] Don't cut off stack traces at 32MB. --- command/server.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/command/server.go b/command/server.go index 1a5fc824039f0..974c914f941a8 100644 --- a/command/server.go +++ b/command/server.go @@ -14,6 +14,7 @@ import ( "os" "path/filepath" "runtime" + "runtime/pprof" "sort" "strconv" "strings" @@ -1969,9 +1970,8 @@ CLUSTER_SYNTHESIS_COMPLETE: } case <-c.SigUSR2Ch: - buf := make([]byte, 32*1024*1024) - n := runtime.Stack(buf[:], true) - c.logger.Info("goroutine trace", "stack", string(buf[:n])) + logWriter := c.logger.StandardWriter(&hclog.StandardLoggerOptions{}) + pprof.Lookup("goroutine").WriteTo(logWriter, 2) } } From 7398eb3fa3d9b3773982d92c814ff4c0dd0734c8 Mon Sep 17 00:00:00 2001 From: Nick Cabatoff Date: Thu, 15 Apr 2021 13:49:44 -0400 Subject: [PATCH 2/2] Add CL --- changelog/11364.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelog/11364.txt diff --git a/changelog/11364.txt b/changelog/11364.txt new file mode 100644 index 0000000000000..64fae590a4fc0 --- /dev/null +++ b/changelog/11364.txt @@ -0,0 +1,3 @@ +```release-note:improvement +core: allow arbitrary length stack traces upon receiving SIGUSR2 (was 32MB) +```