Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cut off stack traces at 32MB. #11364

Merged
merged 2 commits into from Apr 16, 2021
Merged

Don't cut off stack traces at 32MB. #11364

merged 2 commits into from Apr 16, 2021

Conversation

ncabatoff
Copy link
Contributor

I couldn't find a way to maintain the existing prefix "goroutine trace" prefix, but I think that's okay. The result looks like this:

2021-04-15T13:44:42.714-0400 [INFO]  secrets.kv.kv_77220184: upgrading keys finished
2021-04-15T13:44:48.846-0400 [INFO]  goroutine 1 [running]:
runtime/pprof.writeGoroutineStacks(0x63b2400, 0xc00061ad80, 0xd0, 0x55a9bc0)
        /Users/ncc/go/go1.16.2/src/runtime/pprof/pprof.go:693 +0x9f

@ncabatoff ncabatoff added this to the 1.7.1 milestone Apr 15, 2021
@vercel vercel bot temporarily deployed to Preview – vault April 15, 2021 17:50 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 15, 2021 17:50 Inactive
@ncabatoff ncabatoff requested a review from a team April 16, 2021 16:03
vishalnayak
vishalnayak approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new format looks alright and I see no reason to be consistent with the old format.
Although, I suggest take more opinions before merging.

raskchanky
raskchanky approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not real familiar with either runtime or pprof but I guess as long as it's still providing the information we need, it's fine?

@ncabatoff ncabatoff modified the milestones: 1.7.1, 1.6.4 Apr 16, 2021
@ncabatoff ncabatoff merged commit 5a17c4e into master Apr 16, 2021
@ncabatoff ncabatoff deleted the remove-usr2-stacktrace-size-limit branch April 16, 2021 19:55
ncabatoff added a commit that referenced this pull request Apr 16, 2021
@ncabatoff
Don't cut off stack traces at 32MB. (#11364)
af049d9
ncabatoff added a commit that referenced this pull request Apr 16, 2021
@ncabatoff
Don't cut off stack traces at 32MB. (#11364)
f6c81f0
ncabatoff added a commit that referenced this pull request Apr 16, 2021
@ncabatoff
Don't cut off stack traces at 32MB. (#11364) (#11384)
5ed8a98
ncabatoff added a commit that referenced this pull request Apr 16, 2021
@ncabatoff
Don't cut off stack traces at 32MB. (#11364) (#11383)
1ac9329
AndreyZamyslov pushed a commit to yandex-cloud/vault that referenced this pull request Jun 10, 2021
@ncabatoff @AndreyZamyslov
Don't cut off stack traces at 32MB. (hashicorp#11364)
ba89e4b
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
@ncabatoff @jartek
Don't cut off stack traces at 32MB. (hashicorp#11364)
623a2a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskchanky raskchanky raskchanky approved these changes

@vishalnayak vishalnayak vishalnayak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ncabatoff @raskchanky @vishalnayak