Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to look up a lease by ID #11129

Merged
merged 8 commits into from Mar 18, 2021
Merged

Add command to look up a lease by ID #11129

merged 8 commits into from Mar 18, 2021

Conversation

catsby
Copy link
Member

@catsby catsby commented Mar 17, 2021

This PR adds a command under vault lease to look up a lease by ID, implementing/adding the Read Lease endpoint in the Vault CLI

@kalafut
Copy link
Contributor

kalafut commented Mar 17, 2021 •
edited

Can you add a changelog entry?

calvn
calvn approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@vercel vercel bot temporarily deployed to Preview – vault-storybook March 17, 2021 21:20 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 17, 2021 21:20 Inactive
@catsby
Copy link
Member Author

catsby commented Mar 17, 2021

CHANGELOG entry added in a16e2ce , thanks for the nudge there @kalafut

@vercel vercel bot temporarily deployed to Preview – vault-storybook March 18, 2021 00:56 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 18, 2021 00:56 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 18, 2021 13:24 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 18, 2021 13:24 Inactive
@catsby catsby merged commit e7bdccd into master Mar 18, 2021
@catsby catsby deleted the lease-lookup branch March 18, 2021 16:11
@catsby catsby mentioned this pull request Mar 29, 2021
Merged
AndreyZamyslov pushed a commit to yandex-cloud/vault that referenced this pull request Jun 10, 2021
@catsby @AndreyZamyslov
Add command to look up a lease by ID (hashicorp#11129)
bf26cf0 
* snapshot

* basic test

* update command and add documentation

* update help text

* typo

* add changelog for lease lookup command

* run go mod vendor

* remove tabs from help output
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
@catsby @jartek
Add command to look up a lease by ID (hashicorp#11129)
cb4eb0f 
* snapshot

* basic test

* update command and add documentation

* update help text

* typo

* add changelog for lease lookup command

* run go mod vendor

* remove tabs from help output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalafut kalafut kalafut approved these changes

@calvn calvn calvn approved these changes

@ncabatoff ncabatoff ncabatoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@catsby @kalafut @calvn @ncabatoff