Sql Server (mssql) secret backend #998
Conversation
chrishoffman
force-pushed
the
mssql
branch
3 times, most recently
from
94c5e41
to
08eaef9
Compare
|
@chrishoffman Could you sync this with master? At this point it wants to bring in a lot of Godeps stuff that no longer exists. In addition in the last month there have been some significant changes in the MySQL backend and it'd be good to bring these changes in. After that's done I'll be ready to review. Thanks! |
|
Sure thing. |
|
Great! |
|
Everything should be ready to go now. I had most of the changes in the mysql backend already and just added the verify_connection option to the connection config. I had some trouble with the Godeps stuff but I think that is squared away. |
| "max_open_connections": &framework.FieldSchema{ | ||
| Type: framework.TypeInt, | ||
| Description: "Maximum number of open connections to database", | ||
| }, |
There was a problem hiding this comment.
You mentioned about verify_connection in the comments but the changes are not here. Did you miss out on pushing the changes?
There was a problem hiding this comment.
Yes, it looks like I missed this. I'll add it back.
|
@chrishoffman Thank you for this! |
|
The requested updates have been made and I tested the docs and they look good. This is ready again for review. |
| @@ -1,9 +1,6 @@ | |||
| { | |||
| "ImportPath": "github.com/hashicorp/vault", | |||
| "GoVersion": "go1.6", | |||
| "Packages": [ | |||
There was a problem hiding this comment.
These lines need to be here -- can you just manually add them back in?
|
|
||
| func (b *backend) pathRoleDelete( | ||
| req *logical.Request, data *framework.FieldData) (*logical.Response, error) { | ||
| err := req.Storage.Delete("role/" + data.Get("name").(string)) |
There was a problem hiding this comment.
You should ensure that "name" isn't empty before calling Delete or you'll be issuing a delete on the higher level path.
There was a problem hiding this comment.
I could be more explicit here with requiring non-empty roles but the router will not allow any name to be passed here without at least 3 characters. Would you rather me be more explicit here?
There was a problem hiding this comment.
Nope, missed the requirement in the regex. It's all good.
|
I made the requested modifications with the exception of the outstanding roles question. Let me know if the router regular expression is adequate for preventing empty name parameters. |
|
@chrishoffman Thanks for acting on the comments quickly and for the PR in general! |
Sql Server (mssql) secret backend
This request adds support for a MSSQL secret backend. It is modeled after the MySQL backend.
#374