RabbitMQ - bad admin password still returns creds which are invalid

[CHR-LeeOlsen]

Describe the bug
We were migrating to a new RabbitMQ cluster and the infrastructure team used a new password for the admin user that the Vault Policy was configured to use. Instead of Vault throwing an error, it was returning creds that were invalid since it was unable to create the user.

To Reproduce
Change the password of the admin user that Vault is using in RabbitMQ to something different without updating the Vault Policy config.

Expected behavior
Vault should throw an error.

Environment:

• Vault Server Version: 1.3.1

[CHR-LeeOlsen]

Maybe that was fixed here? #8619

[calvn]

It seems that it might be fixed by that PR. @tyrannosaurus-becks would you be able to confirm on this?

[tyrannosaurus-becks]

It definitely could have been solved by that PR. Before, it had been swallowing non-200 responses, and now it fails loudly as it should. @CHR-LeeOlsen would you be willing to test with Vault 1.4.1 or later to see if the problem persists?