Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make the UI build compatible with NodeJS >= 12 #8504

Closed
tsarna opened this issue Mar 8, 2020 · 4 comments
Closed

Please make the UI build compatible with NodeJS >= 12 #8504

tsarna opened this issue Mar 8, 2020 · 4 comments

Comments

@tsarna
Copy link

tsarna commented Mar 8, 2020

The Vault UI cannot be built with NodeJS >= 12, which creates packaging difficulties and results in the UI being disabled on Alpine Linux, and perhaps elsewhere. See:

https://gitlab.alpinelinux.org/alpine/aports/issues/11222

NodeJS 12.x is the current LTS release

@jefferai
Copy link
Member

jefferai commented Mar 8, 2020

Actually Node 10 is still in active mode and flips to maintenance in about two months (https://nodejs.org/en/about/releases/) and is a long way out from being unsupported. Separately from us supporting Node 12, Alpine should really be supporting both releases. This is currently an artificial limitation being imposed by them.

@Ikke
Copy link

Ikke commented Jul 7, 2020

Alpine Linux already maintains 2 versions of nodejs, at the moment 12.x and 14.x. Having to maintain 10.x as well would be a lot of effort just for vault.

On the other side I understand that it's reasonable to depend on nodejs 10 while it's still supported, but until a newer version of nodejs is supported, we'll have to ship vault without any UI.

@Conan-Kudo
Copy link

Conan-Kudo commented Mar 6, 2022

I'm trying to build Vault for RHEL/CentOS 9, which provides only Nodejs 16. There's basically no way for me to build this because the asset build breaks. I attempted to try to get Nodejs 10 working, but it requires Python 2, which not available in RHEL 9. And I can't build Python 2 because it's not compatible with OpenSSL 3.0. And that's where I say I'm done, because I'm not getting into crypto libraries.

At this point, I implore that Vault fixes this so that it works with a maintained LTS Nodejs version. Additionally, I would like for Vault to bundle generated assets in the source tarball per #7350 and #7770.

@hashishaw
Copy link
Collaborator

Hello! We have bumped our required node version to >=14 as of #12049
I'm closing this out but please open a new issue if you run into more problems with the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants