Set request token entry within fetchACLTokenEntryAndEntity #5880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
commented
Nov 30, 2018
| @@ -1146,8 +1146,6 @@ func (c *Core) sealInitCommon(ctx context.Context, req *logical.Request) (retErr | |||
| return retErr | |||
| } | |||
|
|
|||
| req.SetTokenEntry(te) | |||
There was a problem hiding this comment.
This was the only instance that I found where req.SetTokenEntry was called after a fetchACLTokenEntryAndEntity call.
jefferai
approved these changes
Dec 3, 2018
briankassouf
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
fetchACLTokenEntryAndEntity, this change sets the request's token entry to the one returned byLookupfor the case where the token entry was not yet cached.