Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault 1.16.1 missed PR: UI: Fix KV v2 json editor #24224 #26634

Open
timonych opened this issue Apr 24, 2024 · 2 comments
Open

Vault 1.16.1 missed PR: UI: Fix KV v2 json editor #24224 #26634

timonych opened this issue Apr 24, 2024 · 2 comments
Labels
reproduced This issue has been reproduced by a Vault engineer ui

Comments

@timonych
Copy link

timonych commented Apr 24, 2024

Describe the bug
Try to add new line in kv2 json and the pointer goes to start.

To Reproduce

  1. Open any kv2 json.
  2. Click on Create New Version
  3. Put the pointer in some place in json
  4. Press Enter to add new line and the pointer goes to start

Expected behavior
New line successfully added.

Additional context
I think that PR which is fixed behavior in 1.15 is missed in 1.16.1
#24224

@timonych timonych changed the title Vault 1.16.1 missed MR: UI: Fix KV v2 json editor #24224 Vault 1.16.1 missed PR: UI: Fix KV v2 json editor #24224 Apr 24, 2024
@divyaac divyaac added the ui label Apr 25, 2024
@marcboudreau
Copy link
Contributor

I can confirm the reported behaviour is occurring in Vault 1.16.1. Here's a more descriptive explanation of the problem, @timonych let me know if I didn't get it right.

Given this secret,
image

If I place the cursor at the end of line 3 (to the right of the closing double quote character) and press ENTER, the cursor jumps to the beginning of line 1 and no newline character is inserted. However, if I first insert a comma and then press ENTER, the editor works as expected.
image

@marcboudreau marcboudreau added the reproduced This issue has been reproduced by a Vault engineer label Apr 29, 2024
@timonych
Copy link
Author

@marcboudreau Yes. You are clearily described the problem. thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reproduced This issue has been reproduced by a Vault engineer ui
Projects
None yet
Development

No branches or pull requests

3 participants