Convert to logxi #1755
Merged
Convert to logxi #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
force-pushed
the
logxi
branch
17 times, most recently
from
fa89965
to
803696c
Compare
| @@ -281,18 +291,20 @@ func (b *backend) getLdapGroups(cfg *ConfigEntry, c *ldap.Conn, userDN string, u | |||
| ldapMap := make(map[string]bool) | |||
|
|
|||
| if cfg.GroupFilter == "" { | |||
| b.Logger().Printf("[WARN] auth/ldap: GroupFilter is empty, will not query server") | |||
| b.Logger().Warn("auth/ldap: GroupFilter is empty, will not query server") | |||
There was a problem hiding this comment.
IsWarn check is missing here and in the next log message as well.
As a general comment, it is a real pain to check IsDebug or IsWarn before printing anything.
Is it not possible that the Logger().Debug() will only print if Debug is enabled. So we can conveniently skip the check.
There was a problem hiding this comment.
Discussed in Slack; saves the cost of creating arguments. So it's only
used when there are arguments, and optional even then (but good).
jefferai
force-pushed
the
logxi
branch
2 times, most recently
from
ba934f6
to
dedbf27
Compare
| c.Ui.Output(fmt.Sprintf("Unknown log level %s", logLevel)) | ||
| return 1 | ||
| } | ||
| switch os.Getenv("LOGXI_FORMAT") { |
There was a problem hiding this comment.
Should we rename this to VAULT_LOGXI_FORMAT?
There was a problem hiding this comment.
Right now this isn't really exposed, but the nice thing about leaving
it as-is is that people can use normal logxi formatters too.
jefferai
force-pushed
the
logxi
branch
3 times, most recently
from
ed5480d
to
821c71f
Compare
| writer.Write([]byte(" [ALL] ")) | ||
| } | ||
|
|
||
| writer.Write([]byte(msg + " ")) |
There was a problem hiding this comment.
If we remove the " " from here, we can remove the if i > 0 { check below?
There was a problem hiding this comment.
Good point -- can't remove here, but can remove the one after msg.
|
LGTM! Very good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.