Backport of VAULT-8630 Fix goroutine leak from RLQ initialize into release/1.11.x #17286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/violethynes/VAULT-8630/willingly-daring-dog
branch
from
ad8cfe1
to
9b5245c
Compare
VioletHynes
approved these changes
Sep 22, 2022
jasonodonnell
deleted the
backport/violethynes/VAULT-8630/willingly-daring-dog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17281 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
The below text is copied from the body of the original PR.
We current have a goroutine leak since as part of creating RLQs, we create a goroutine as part of
memorystore.New- however, as part ofReset, we don’t actually callCloseon it. As a result, upon seal/unseal, a lot of these goroutines get stranded.This could cause an issue with a combination of high leadership changes and high quotas.
I tested this manually and this definitely fixes things. Adding a non-manual test doesn't seem particularly easy/possible due to our existing leaks.
Overview of commits