Backport of agent/auto-auth: add exit_on_err configurable into release/1.11.x #17156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from taoism4504
as a code owner
hc-github-team-secure-vault-core
requested review from
a team and
jasonodonnell
hc-github-team-secure-vault-core
force-pushed
the
backport/exit-on-err-auto-auth/surely-oriented-toucan
branch
from
94645b6
to
3d5d6d6
Compare
jasonodonnell
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17091 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
The below text is copied from the body of the original PR.
When Agent's auto-auth encounters a problem it will retry indefinitely, regardless of the error. This configurable allows users to specify if Vault should exit on auto-auth error, similar to
exit_on_errin the caching engine: https://www.vaultproject.io/docs/agent/caching#exit_on_err.At the moment this will exit on any error, but I'm open to only exiting on some errors (such as 400 errors).
Overview of commits