AppRole backend #1426
Merged
AppRole backend #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Lock to make changes to registered Apps | ||
| appLock *sync.RWMutex | ||
|
|
||
| // Lock to make changes to registered Apps |
vishalnayak
force-pushed
the
appgroup-backend
branch
2 times, most recently
from
0e549b4
to
dc234e5
Compare
vishalnayak
force-pushed
the
appgroup-backend
branch
4 times, most recently
from
b401096
to
b1549d8
Compare
vishalnayak
force-pushed
the
appgroup-backend
branch
2 times, most recently
from
3a1eb7a
to
35bd5cd
Compare
| HelpDescription: strings.TrimSpace(roleHelp["role-bound-cidr-list"][1]), | ||
| }, | ||
| &framework.Path{ | ||
| Pattern: "role/" + framework.GenericNameRegex("role_name") + "/bound-secret-id$", |
vishalnayak
force-pushed
the
appgroup-backend
branch
5 times, most recently
from
51b907a
to
553756e
Compare
jefferai
force-pushed
the
appgroup-backend
branch
from
553756e
to
afc06a5
Compare
vishalnayak
force-pushed
the
appgroup-backend
branch
from
afc06a5
to
59930fd
Compare
| the client, it is referred as a `Push` mode. | ||
|
|
||
| While the `user_id` of the App-ID backend worked in a `Push` mode, this backend | ||
| recommends the `Pull` mode. The `Pull` mode is supported in AppRole backend, |
There was a problem hiding this comment.
@vishalnayak shouldn't this say "The Push mode is supported in AppRole backend only to be able to…"?
Or have I totally misunderstood things? :)
There was a problem hiding this comment.
@sandstrom, it says that in the master branch :-)
rajanadar
added a commit
to rajanadar/VaultSharp
that referenced
this pull request
Aug 29, 2016
rajanadar
added a commit
to rajanadar/VaultSharp
that referenced
this pull request
Aug 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.