Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.8.2: Handle api explorer routing error (#12354) #12385

Merged
merged 2 commits into from Aug 20, 2021

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented Aug 20, 2021

No description provided.

* Handle api explorer routing error

- For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError
- As a fix treat this particular error as success since it doesn't interfere in the routing
- Reference: emberjs/ember-test-helpers#332

* Added changelog
@arnav28 arnav28 requested a review from a team August 20, 2021 05:31
@arnav28 arnav28 changed the base branch from main to release/1.8.x August 20, 2021 05:32
@arnav28 arnav28 added this to the 1.8.2 milestone Aug 20, 2021
@arnav28 arnav28 added the ui label Aug 20, 2021
@arnav28
Copy link
Contributor Author

arnav28 commented Aug 20, 2021

Backport of #12354

@arnav28 arnav28 removed the request for review from a team August 20, 2021 05:39
@vercel vercel bot temporarily deployed to Preview – vault August 20, 2021 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 20, 2021 16:47 Inactive
@arnav28 arnav28 merged commit b882dde into release/1.8.x Aug 20, 2021
@arnav28 arnav28 deleted the ui/backport-pr-12354-1.8.x branch August 23, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants