Handle api explorer routing error #12354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arnav28
commented
Aug 18, 2021
arnav28
commented
- For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError
- As a fix treat this particular error as success since it doesn't interfere in the routing
- Reference: visit() throws TransitionAborted error emberjs/ember-test-helpers#332
- For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError - As a fix treat this particular error as success since it doesn't interfere in the routing - Reference: emberjs/ember-test-helpers#332
|
|
Monkeychip
approved these changes
Aug 19, 2021
arnav28
added a commit
that referenced
this pull request
Aug 20, 2021
* Handle api explorer routing error - For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError - As a fix treat this particular error as success since it doesn't interfere in the routing - Reference: emberjs/ember-test-helpers#332 * Added changelog
arnav28
added a commit
that referenced
this pull request
Aug 20, 2021
* Handle api explorer routing error - For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError - As a fix treat this particular error as success since it doesn't interfere in the routing - Reference: emberjs/ember-test-helpers#332 * Added changelog
arnav28
added a commit
that referenced
this pull request
Aug 20, 2021
* Handle api explorer routing error - For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError - As a fix treat this particular error as success since it doesn't interfere in the routing - Reference: emberjs/ember-test-helpers#332 * Added changelog
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
* Handle api explorer routing error - For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError - As a fix treat this particular error as success since it doesn't interfere in the routing - Reference: emberjs/ember-test-helpers#332 * Added changelog
arnav28
added a commit
that referenced
this pull request
Sep 15, 2021
* Handle api explorer routing error - For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError - As a fix treat this particular error as success since it doesn't interfere in the routing - Reference: emberjs/ember-test-helpers#332 * Added changelog
arnav28
added a commit
that referenced
this pull request
Sep 16, 2021
* Handle api explorer routing error - For some reason when routing is done during async process, router transtionTo throws the TransitionAbortedError - As a fix treat this particular error as success since it doesn't interfere in the routing - Reference: emberjs/ember-test-helpers#332 * Added changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.