Userpass: Update the password and policies associated to user #1216
Conversation
| @@ -109,6 +109,98 @@ func TestBackend_userCrud(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestBacken_userCreateOperation(t *testing.T) { | |||
| return false, fmt.Errorf("missing username") | ||
| } | ||
|
|
||
| entry, err := req.Storage.Get("user/" + strings.ToLower(username)) |
There was a problem hiding this comment.
You should use the same logic here that you're using in userCreateUpdate, just to be safe in case something diverges. So that probably means using b.user() here.
vishalnayak
force-pushed
the
userpass-update
branch
from
d3d9e06
to
cfbab2c
Compare
| return false, fmt.Errorf("missing username") | ||
| } | ||
|
|
||
| userEntry, err := b.user(req.Storage, username) |
There was a problem hiding this comment.
If username is always the name of the value, you can simply pass in data to b.user and have it return an error if there is a missing username. This lets you remove this check in a few other places too.
There was a problem hiding this comment.
Ah, this is called in pathLoginRenew. Even so, you can pass data.Get("username").(string) directly in and check if it's empty in b.user
| } | ||
| } | ||
|
|
||
| func (b *backend) userPasswordExistenceCheck(req *logical.Request, data *framework.FieldData) (bool, error) { |
There was a problem hiding this comment.
This all looks much better -- please do add a comment though explaining why this existence check always returns true.
There was a problem hiding this comment.
(For future code-browsers to avoid scratching heads.)
Userpass: Update the password and policies associated to user
No description provided.