Add fallback font for masked-input #12152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav28
approved these changes
Jul 22, 2021
Monkeychip
added a commit
that referenced
this pull request
Jul 23, 2021
* add fallback font for higher unicode coverage * remove extra mixin and fix color issue that was not working on binary
Monkeychip
added a commit
that referenced
this pull request
Jul 23, 2021
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
* add fallback font for higher unicode coverage * remove extra mixin and fix color issue that was not working on binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this issue and potential other unicode characters that our custom font does not cover.
The fallback font comes from this npm package and provides more converage than our custom font.
See gif of Cyrillic characters.
