Accessor paths for lookup and revocation of tokens #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or code in all the responses
| @@ -28,6 +28,7 @@ type Secret struct { | |||
| // SecretAuth is the structure containing auth information if we have it. | |||
| type SecretAuth struct { | |||
| ClientToken string `json:"client_token"` | |||
| AccessorID string `json:"accessor_id"` | |||
There was a problem hiding this comment.
I know this is going to be an annoying code change, but...I don't like "AccessorID". I used "Accessor" in the RFC because it's a noun; calling it an AccessorID means that it's an ID of the accessor, which is not what it is. "AccessID" could work, but I preferred Accessor over AccessID because AccessID could be confused as the actual important value (a value to "access Vault").
There was a problem hiding this comment.
Not an annoying change :) I'll do it.
|
Looking pretty good, left a few comments. |
vishalnayak
changed the title
vishalnayak
force-pushed
the
token-accessors
branch
from
6e0e5fd
to
c7c9e0b
Compare
|
LGTM! |
vishalnayak
added a commit
that referenced
this pull request
Mar 9, 2016
Accessor paths for lookup and revocation of tokens
rajanadar
added a commit
to rajanadar/VaultSharp
that referenced
this pull request
Aug 30, 2016
rajanadar
added a commit
to rajanadar/VaultSharp
that referenced
this pull request
Aug 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API documentation and Tests pending. Do Not Merge.