From 644d9f3dffb3b9d0af6468aa09461ef78bb90ef6 Mon Sep 17 00:00:00 2001 From: Christopher Swenson Date: Thu, 25 Aug 2022 09:53:14 -0700 Subject: [PATCH] Add version to plugin and logical tests --- vault/logical_system_test.go | 2 +- vault/plugin_catalog_test.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/vault/logical_system_test.go b/vault/logical_system_test.go index 9c1e90f0ec74a..52fc91437eb2d 100644 --- a/vault/logical_system_test.go +++ b/vault/logical_system_test.go @@ -2996,7 +2996,7 @@ func TestSystemBackend_PluginCatalog_CRUD(t *testing.T) { "args": []string(nil), "sha256": "", "builtin": true, - "version": "", + "version": c.pluginCatalog.getBuiltinVersion(consts.PluginTypeDatabase, "mysql-database-plugin"), } if !reflect.DeepEqual(actualRespData, expectedRespData) { t.Fatalf("expected did not match actual, got %#v\n expected %#v\n", actualRespData, expectedRespData) diff --git a/vault/plugin_catalog_test.go b/vault/plugin_catalog_test.go index bf4c5b97605ac..59837ee7ef829 100644 --- a/vault/plugin_catalog_test.go +++ b/vault/plugin_catalog_test.go @@ -37,6 +37,7 @@ func TestPluginCatalog_CRUD(t *testing.T) { Name: "mysql-database-plugin", Type: consts.PluginTypeDatabase, Builtin: true, + Version: core.pluginCatalog.getBuiltinVersion(consts.PluginTypeDatabase, "mysql-database-plugin"), } expectedBuiltin.BuiltinFactory, _ = builtinplugins.Registry.Get("mysql-database-plugin", consts.PluginTypeDatabase) @@ -98,6 +99,7 @@ func TestPluginCatalog_CRUD(t *testing.T) { Name: "mysql-database-plugin", Type: consts.PluginTypeDatabase, Builtin: true, + Version: core.pluginCatalog.getBuiltinVersion(consts.PluginTypeDatabase, "mysql-database-plugin"), } expectedBuiltin.BuiltinFactory, _ = builtinplugins.Registry.Get("mysql-database-plugin", consts.PluginTypeDatabase)