Prevent the pattern matching for KV V2 operations if a trailing slash… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
reviewed
Sep 27, 2022
tomhjp
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is present in the URL
Overview
Kv v1 secrets engine returns a 404 if you attempt to perform actions on an endpoint with a trailing slash (i.e. an endpoint that doesn't exist).
KV v2 however allows this, but due to the way it handles metadata via the storage backends this can lead to a situation where a
500 Internal Server Erroris returned as the secret cannot be found, but metadata can.This change prevents the code from running by adjusting the pattern matcher in the framework.
Solves: VAULT-6804