removed orphaned data sources from the working state #27621
Merged
+60
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When evaluating orphaned data sources during plan, they need to be removed from both the refresh state and the current working state.
Codecov Report
|
jbardin
commented
Jan 28, 2021
| _, diags = ctx.Apply() | ||
| if diags.HasErrors() { | ||
| t.Fatal(diags.Err()) | ||
| } |
There was a problem hiding this comment.
This slipped into the change from the file I had open already, but I left it since it's a bit of code that should have been deleted. Apply shouldn't be called in the plan test, and does not check anything.
mildwonkey
approved these changes
Jan 29, 2021
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing data source instances via alterations to a
for_eachvalue, the orphaned instance must be removed from both the refresh state, and the working state. While therefreshStaterepresents what the data source is currently, plan-time evaluations will still happen against the working state.Fixes #27617
This will require a manual backport for 0.14