Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update complex constraints in core schema to allow any expressions #214

Open
radeksimko opened this issue May 11, 2023 · 0 comments · May be fixed by #216
Open

Update complex constraints in core schema to allow any expressions #214

radeksimko opened this issue May 11, 2023 · 0 comments · May be fixed by #216
Assignees
@radeksimko
Labels
technical-debt

Comments

@radeksimko
Copy link
Member

Context

After introducing AnyExpression as part of #174 we forgot to also update certain parts of the core schema which involve complex type constraints, such as provisioner blocks:

terraform-schema/internal/schema/0.12/provisioners.go

Lines 118 to 125 in 664a8e0

"inline": {
IsOptional: true,
Constraint: schema.List{
Elem: schema.AnyExpression{OfType: cty.String},
},
Description: lang.Markdown("A list of command strings. They are executed in the order they are provided." +
" This cannot be provided with `script` or `scripts`."),
},

This means that currently we don't allow interpolation in various places, e.g.

Screenshot 2023-05-11 at 16 49 19

Proposal

Go through all places where we use schema.List, schema.Set, schema.Tuple, schema.Map and schema.Object and check if they need updating to schema.OneOf{} variation, such as

terraform-schema/schema/convert_json_test.go

Lines 191 to 196 in 664a8e0

Constraint: schema.OneOf{
schema.AnyExpression{OfType: cty.List(cty.String), SkipLiteralComplexTypes: true},
schema.List{
Elem: schema.AnyExpression{OfType: cty.String},
},
},

@radeksimko radeksimko linked a pull request May 14, 2023 that will close this issue
Draft
1 task
@radeksimko radeksimko self-assigned this May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeksimko radeksimko

Labels
technical-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update complex constraints to allow interpolation hashicorp/terraform-schema
1 participant
@radeksimko