Add support for "High with Hyperthreading" option for latency_sensitivity

[Guerckan]

Community Guidelines

• I have read and agree to the HashiCorp Community Guidelines .
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

As introduced by vSphere 8.0, the "latency sensitivity" virtual machine setting now has a new possible value named "High with Hyperthreading".
See VMWare documentation supporting this statement : https://docs.vmware.com/en/VMware-vSphere/8.0/vsphere-vm-administration/GUID-F5DAC793-7B13-418F-949E-0CD80CEC5D1E.html

Current provider implementation (2.7.0 at the time of writing) of the resource vsphere_virtual_machine does not support this new value as specified here : https://registry.terraform.io/providers/hashicorp/vsphere/latest/docs/resources/virtual_machine#latency_sensitivity

Use Case(s)

This setting is particularly interesting for network appliances virtual machines and the new functionality of "high with hyperthreading" offers a way to reduce the computing power footprint of a latency sensitivity "high" setting on the host without sacrificing much of its advantages.

Potential Terraform Provider Configuration

No response

References

No response

[github-actions]

Hello, Guerckan! 🖐

Thank you for submitting an issue for this provider. The issue will now enter into the issue lifecycle.

If you want to contribute to this project, please review the contributing guidelines and information on submitting pull requests.

[tenthirtyam]

This item has an upstream dependency on [vmware/govmomi](https://github.com/vmware/govmomi/blob/bf28314d9e3287ad1674f80d8a80d2245c0159ae/vim25/types/enum.go#L4846-L4881) which would need to support values other than Low, Normal, Medium, and High. Once available and the dependency is updated, the virtualMachineLatencySensitivityAllowedValues could be updated to support the new value.

For example:

terraform-provider-vsphere/vsphere/virtual_machine_config_structure.go

Lines 54 to 59 in 413892c

	var virtualMachineLatencySensitivityAllowedValues = []string{
	string(types.LatencySensitivitySensitivityLevelLow),
	string(types.LatencySensitivitySensitivityLevelNormal),
	string(types.LatencySensitivitySensitivityLevelMedium),
	string(types.LatencySensitivitySensitivityLevelHigh),
	}

to...

var virtualMachineLatencySensitivityAllowedValues = []string{
	string(types.LatencySensitivitySensitivityLevelLow),
	string(types.LatencySensitivitySensitivityLevelNormal),
	string(types.LatencySensitivitySensitivityLevelMedium),
	string(types.LatencySensitivitySensitivityLevelHigh),
        string(types.LatencySensitivitySensitivityLevelHighHyperthreading), # Example
}

Please consider opening an upstream enhancement in vmware/govmomi.

Ryan Johnson
Distinguished Engineer, VMware by Broadcom

[Guerckan]

Thank you for your help @tenthirtyam !
Upstream enhancement request has been opened as requested.