Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding proxy support #154

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding proxy support #154

wants to merge 4 commits into from

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Jul 8, 2022 •
edited

Using implementation of proxy support in tls provider to add proxy support.

Proxy can be configured using:

  • URL and, optionally supplying username and password
  • env vars

This needs to be refactored once validators for ConflictsWith and RequiredWith become available.

Closes: #80

@bendbennett bendbennett marked this pull request as ready for review July 8, 2022 14:45
@bendbennett bendbennett requested a review from a team as a code owner July 8, 2022 14:45
@bendbennett bendbennett added this to the v3.1.0 milestone Jul 9, 2022
@bendbennett bendbennett modified the milestones: v3.1.0, v3.2.0 Aug 22, 2022
@bendbennett bendbennett removed this from the v3.2.0 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detro detro detro approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies documentation size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for proxy environments variables (HTTP_PROXY/HTTPS_PROXY)
2 participants
@bendbennett @detro