Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add HTTPS Resource Request #300

Open
1 task done
srikanth2302 opened this issue Jul 24, 2023 · 5 comments
Open
1 task done

Feature: Add HTTPS Resource Request #300

srikanth2302 opened this issue Jul 24, 2023 · 5 comments

Comments

@srikanth2302
Copy link

srikanth2302 commented Jul 24, 2023

Terraform CLI and Provider Versions

Terraform CLI Version: v1.3.6
Provider Version: 3.4.0

Use Cases or Problem Statement

I Would like to have a http resource request so that terraform can perform the Post Operation only if Attributes of the resource changed. DataSource is continuously performing POST Request which is not required.

Proposal

Something like below `

resource "http" "Post_Request" {
  name         = "vault-mount"
  url          = "https://localhost:8200/v1/sys/mounts/"
  method       = "POST"
  request_body = <<EOF
{
  "type": "aws",
  "config": {
    "force_no_cache": true
  }
}

EOF

  headers = {
    X-Vault-Token = "xxx"
  }
}

How much impact is this issue causing?

High

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bendbennett
Copy link
Contributor

bendbennett commented Jul 25, 2023

Hi @srikanth2302 👋

Thank you for raising this issue. We will leave this issue open and prioritise looking into this further on the basis of the level of community interest that is expressed.

Related: #241

@ShubhamKumar977
Copy link

Hi @bendbennett

I think this would be a good feature

Terraform CLI and Provider Versions

Terraform CLI Version: v1.3.6 Provider Version: 3.4.0

Use Cases or Problem Statement

I Would like to have a http resource request so that terraform can perform the Post Operation only if Attributes of the resource changed. DataSource is continuously performing POST Request which is not required.

Proposal

Something like below `

resource "http" "Post_Request" {
  name         = "vault-mount"
  url          = "https://localhost:8200/v1/sys/mounts/"
  method       = "POST"
  request_body = <<EOF
{
  "type": "aws",
  "config": {
    "force_no_cache": true
  }
}

EOF

  headers = {
    X-Vault-Token = "xxx"
  }
}

How much impact is this issue causing?

High

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Hi @bendbennett,

It would be good to have this as a resource. Can you please prioritize this enhancement.

@bendbennett
Copy link
Contributor

Hi @ShubhamKumar977 👋

Could you signal your interest in this issue by adding a 👍 to #300 (comment). Thanks!

@varshith1212
Copy link

Hi @bendbennett

This seems to be a reasonable request, I also have a use case not to execute data source, and having a resource would suit the requirement that we are trying to achieve...
Can you prioritize this enhancement?

@srikanth2302
Copy link
Author

@bendbennett -- Any Update on this request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants