Support VM max_run_duration with instance_termination_action=STOP

[arungantasala]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to a user, that user is claiming responsibility for the issue.
• Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Max run duration(MRD) feature support in terraform was added in PR 6812. There are behavioral changes in the feature which needs further changes.

1. max_run_duration is not a one time intent
2. Add STOP instance termination action with MRD
3. Support MRD on instances with attached local SSDs.

New or Affected Resource(s)

• google_compute_instance
• google_compute_instance_template

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_compute_instance" "foo" {
  # ...
  scheduling {
    max_run_duration {
      nanos = 123
      seconds = 60
    }
    on_instance_stop_action {
      discard_local_ssd = true
  }
}

References

• Internal Issue (http://b/311011584)

[arungantasala]

Fixed in #10683