Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Add scrubbing for sensitive data in logs #26029

Closed
gdavison opened this issue Jul 28, 2022 · 4 comments · Fixed by #29223
Closed

provider: Add scrubbing for sensitive data in logs #26029

gdavison opened this issue Jul 28, 2022 · 4 comments · Fixed by #29223
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS.
Milestone

Comments

@gdavison
Copy link
Contributor

When the log level is set to TRACE, the AWS Provider is logging sensitive values such as access keys.

The AWS SDKs for Go provide some scrubbing for logs, but more checks need to be added.

Determine what is leaking the sensitive values. If needed, evaluate hashicorp/terraform-plugin-sdk#1006, which will be released in terraform-plugin-sdk v2.20.0. This will require adding the option to set the HTTP transport in aws-sdk-go-base.

References

@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 28, 2022
@ewbankkit ewbankkit added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jul 28, 2022
@ewbankkit
Copy link
Contributor

ewbankkit commented Oct 11, 2022

#26732 introduces CodeQL code scanning, which scans for Clear-text logging of sensitive information - log statements that print structures containing password fields.
We will continue to ensure that such logging is removed but this does not handle any other sensitive data.

@gdavison gdavison self-assigned this Oct 27, 2022
@gdavison
Copy link
Contributor Author

gdavison commented Jan 9, 2023

Depends on #15090 to use context.Context everywhere

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This functionality has been released in v4.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants