Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource to manage load balancer attachment for ECS services #23838

Closed
syskill opened this issue Mar 23, 2022 · 2 comments
Closed

New resource to manage load balancer attachment for ECS services #23838

syskill opened this issue Mar 23, 2022 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/ecs Issues and PRs that pertain to the ecs service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@syskill
Copy link

syskill commented Mar 23, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Now that the load balancers for an ECS service can be updated without destroying and re-creating the service (cf. #23596), it would be nice to have a separate resource to manage this association for a pre-existing ECS service, along the lines of aws_lb_target_group_attachment and aws_autoscaling_attachment.

New or Affected Resource(s)

  • aws_ecs_service_attachment

Potential Terraform Configuration

resource "aws_ecs_service_attachment" "example" {
  service_name     = data.aws_ecs_service.my_mongo.service_name 
  target_group_arn = aws_lb_target_group.example.arn
  container_name   = "mongo"
  container_port   = 8080
} 

The user should be able to specify either target_group_arn for an Application Load Balancer, or elb_name for a Classic Load Balancer.

If the ECS service is managed by other Terraform code, then its aws_ecs_service resource would need a lifecycle block to ignore changes to load_balancer configuration.

References

@syskill syskill added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 23, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. labels Mar 23, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 24, 2022
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Mar 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/ecs Issues and PRs that pertain to the ecs service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

2 participants