Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS ECS service propagate_tags without destroy & recreate #23581

Closed
jawon-benchling opened this issue Mar 8, 2022 · 3 comments · Fixed by #23600
Closed

AWS ECS service propagate_tags without destroy & recreate #23581

jawon-benchling opened this issue Mar 8, 2022 · 3 comments · Fixed by #23600
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@jawon-benchling
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently, changing the value of aws_ecs_service.propagate_tags triggers a destroy & recreate of the entire service. It looks like there is now a way to update this value through the UpdateService API
https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_UpdateService.html#API_UpdateService_RequestSyntax

Would it be possible to make it so that propagate_tags can be changed in terraform without destroy & recreate?

New or Affected Resource(s)

  • aws_ecs_service

References

@jawon-benchling jawon-benchling added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 8, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. labels Mar 8, 2022
@md5
Copy link
Contributor

md5 commented Mar 9, 2022

AWS Go SDK support seems to have landed in 1.43.13 as part of aws/aws-sdk-go#4305

@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
3 participants