Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_eks_node_group: Support new Bottlerocket AMI types #21548

Closed
z0rc opened this issue Oct 29, 2021 · 4 comments · Fixed by #21616
Closed

aws_eks_node_group: Support new Bottlerocket AMI types #21548

z0rc opened this issue Oct 29, 2021 · 4 comments · Fixed by #21616
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Milestone

Comments

@z0rc
Copy link

z0rc commented Oct 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

EKS added native support of Bottlerocket to Managed Node Groups https://aws.amazon.com/about-aws/whats-new/2021/10/amazon-eks-nodes-groups-bottlerocket/. aws_eks_node_group attribute ami_type should support new values BOTTLEROCKET_ARM_64 and BOTTLEROCKET_x86_64 according to https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateNodegroup.html#AmazonEKS-CreateNodegroup-request-amiType

New or Affected Resource(s)

  • aws_eks_node_group

Potential Terraform Configuration

resource "aws_eks_node_group" "workers" {
  ...
  ami_type        = "BOTTLEROCKET_x86_64"
  release_version = "1.3.0-395b459c"
  ...
}
@z0rc z0rc added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 29, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/eks Issues and PRs that pertain to the eks service. labels Oct 29, 2021
@z0rc
Copy link
Author

z0rc commented Oct 29, 2021

Requires aws-sdk-go 1.41.12, see aws/aws-sdk-go#4148. Probably will be fixed by #21544. But resource documentation still needs an update.

@z0rc z0rc changed the title aws_eks_node_group: Support new AMI types for Bottlerocket aws_eks_node_group: Support new Bottlerocket AMI types Oct 29, 2021
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 29, 2021
@ewbankkit ewbankkit added the documentation Introduces or discusses updates to documentation. label Nov 2, 2021
@stuart-blackler-cko
Copy link

Interested in this support + subbing

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
4 participants