Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove function + attached resolver #15480

Open
andrewp-sf opened this issue Oct 5, 2020 · 2 comments
Open

Cannot remove function + attached resolver #15480

andrewp-sf opened this issue Oct 5, 2020 · 2 comments
Labels
bug Addresses a defect in current functionality. service/appsync Issues and PRs that pertain to the appsync service.

Comments

@andrewp-sf
Copy link

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.12.28
AWS provider v2.70.0

Affected Resource(s)

  • aws_appsync_function
  • aws_appsync_resolver

Description

Terraform correctly creates above resources and sets up implicit dependency from resolver to function, when pipeline_config is created. However due to AWS limitations of this relation, destroying those two resources at same run/deployment is resulting in a failure.
Before there are comments of 'did you try on 0.13' - no I haven't, that's a luxury I can't afford at this moment as infrastructure that I'm working on is big and mature, we have upgrade in roadmap but not anytime soon.

I'm looking for a solution or a workaround that will solve this, or at least will be solved once we upgrade.

Terraform Configuration Files

Note: incomplete and dummy part of code, but should give an idea of a problem

resource "aws_appsync_resolver" "dummy_resolver" {
  kind              = "PIPELINE"
  api_id            = aws_appsync_graphql_api.dummy.id
  field             = "dummyField"
  type              = "Query"
  request_template  = "SOME_TEMPLATE"
  response_template = "SOME_TEMPLATE"
  depends_on = [
    aws_appsync_graphql_api.dummy,
  ]
  pipeline_config {
    functions = [
      "${aws_appsync_function.dummy.function_id}"
    ]
  }
}

resource "aws_appsync_function" "dummy" {
  api_id                    = aws_appsync_graphql_api.dummy.id
  data_source               = aws_appsync_datasource.dummy.name
  name                      = "dummyField"
  request_mapping_template  = "SOME_TEMPLATE"
  response_mapping_template = "SOME_TEMPLATE"
}

resource "aws_appsync_datasource" "dummy" {
  api_id = aws_appsync_graphql_api.dummy.id
  name   = "dummy_datasource"
  type   = "NONE"
}

Panic Output

Error: Error deleting AppSync Function .....: BadRequestException: Cannot delete a function which is currently used by a resolver. Resolver type: Query, field: ....

Error: BadRequestException: Data source is still in use by functions: [....]

Expected Behavior

There has to be reversed dependency when it comes to destroying/updating. Resolver MUST be updated/removed before function, this is AWS requirement.
On creation however it stays as it is right now, function has to be created before it is attached to resolver.

Actual Behavior

Because of implicit dependency, on destroy function is deleted first, and it can't as it's attached to resolver configuration. Adding explicit dependency results in cycle error.

Steps to Reproduce

Create any resolver and function in pipeline_config setup, then remove them from hcl code and run terraform to destroy them.

@ghost ghost added the service/appsync Issues and PRs that pertain to the appsync service. label Oct 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2020
@breathingdust breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 16, 2021
@ewoelfel
Copy link

I guess this is more an aws issue than a terraform one (see: aws/aws-appsync-community#146)

@klaucode
Copy link

klaucode commented Jan 10, 2023

Is it something new according this issue? We have a same error msg., when TF apply, then rename some function, which is linked to resolver and then TF apply again.

tested on TF 1.3.4 with aws prov. 4.38.0, 1.3.7 with 4.49.0 and alpha1.4.0 20221207 with 4.49.0, still the same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/appsync Issues and PRs that pertain to the appsync service.
Projects
None yet
Development

No branches or pull requests

4 participants